What are the pros and cons of the Soviet-German agreements?

Soviet-German agreements during the Interbellum period (the period between the two world conflicts), several agreements on interaction and economic cooperation were signed in 1922 in Rapallo and in 1926 in Berlin. According to these agreements, centers for the training of German pilots and tankers were deployed on the territory of the USSR, which, subsequently, played against the USSR during the conflict with the Third Reich in 1941-1945. The non-aggression pact of August 1939 allowed the Reich and the USSR to conquer Europe without fear of collision.